Skip to content

Revert spawner reordering #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Revert spawner reordering #547

wants to merge 4 commits into from

Conversation

@christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Jul 29, 2024

Follow-up to #540.

Re-evalute if there is a fix for ros2/rclpy#1320

@christophfroehlich christophfroehlich changed the base branch from master to add_launch_tests July 29, 2024 13:09
Base automatically changed from add_launch_tests to master July 30, 2024 07:14
@christophfroehlich christophfroehlich force-pushed the revert_spawner_reordering branch from 19402fb to a1fde13 Compare July 30, 2024 07:43
@ros-controls ros-controls deleted a comment from mergify bot Jul 30, 2024
@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2024

This pull request is in conflict. Could you fix it @christophfroehlich?

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label Jul 2, 2025
@mergify
Copy link
Contributor

mergify bot commented Jul 2, 2025

This pull request is in conflict. Could you fix it @christophfroehlich?

@github-actions github-actions bot removed the stale label Jul 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2025

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label Aug 18, 2025
@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2025

This pull request is in conflict. Could you fix it @christophfroehlich?

@github-actions github-actions bot removed the stale label Aug 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label Oct 6, 2025
@christophfroehlich christophfroehlich mentioned this pull request Nov 14, 2025
Open
@christophfroehlich christophfroehlich marked this pull request as ready for review November 14, 2025 09:04
@christophfroehlich
Copy link
Contributor Author

christophfroehlich commented Nov 14, 2025

Now the tests passes, unsure if the linked issue got fixes or it is just seldomly flaky.

@github-actions github-actions bot removed the stale label Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@destogl destogl Awaiting requested review from destogl

@erickisos erickisos Awaiting requested review from erickisos

@harderthan harderthan Awaiting requested review from harderthan

@mhubii mhubii Awaiting requested review from mhubii

@olivier-stasse olivier-stasse Awaiting requested review from olivier-stasse

@rosterloh rosterloh Awaiting requested review from rosterloh

@saikishor saikishor Awaiting requested review from saikishor

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@christophfroehlich